-
Notifications
You must be signed in to change notification settings - Fork 58
Issue #903: update to Checkstyle 12.1.0 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Our P2 repo is massive and GitHub Pages chokes on it. |
|
Looks like we ship a lot of dependencies in our update site since #475. Not sure it was intended to include so much... |
|
Actually, the releases are 16MB smaller since then: |
|
Our p2 repository is 8GB. Note that the plugin size increase from 34MB to 110MB with version 10.5.0 so it would be nice to bring this back down eventually. |
|
I think the intent was to add some bundles that are automatically wrapped from maven artifacts during the build, but that a quick fix was to just include all dependencies. Maybe we can just list those explicitly to be included in the p2 repo. Also, we already have the major version number in the p2 url when installing the plugin. Maybe we could instead have one GitHub repository per major version? |
Yes, looks like the only good solution for now. @Calixte , do you need anything from me to make it? |
Fixes #903