Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #502: update to LTS 9.9; cleanup deprecations #503

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

muhlba91
Copy link
Contributor

@muhlba91 muhlba91 commented Mar 1, 2024

fixes #502
fixes #220
fixes #194

Also, remove the deprecated and to be removed ProfileImporter and ProfileExporter.

Screenshots of the working SQ:
Screenshot 2024-03-01 at 1 01 56 PM
Screenshot 2024-03-01 at 1 01 35 PM

@muhlba91
Copy link
Contributor Author

muhlba91 commented Mar 1, 2024

@romani the main project deprecated AutomaticBean a while ago with the reference one should use AbstractAutomaticBean.

unfortunately, by doing so, i now receive a CS error:

[ERROR] [checkstyle] [ERROR] /projects/checkstyle/sonar-checkstyle/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java:41:1: Disallowed import - com.puppycrawl.tools.checkstyle.AbstractAutomaticBean. [ImportControlMain]

could you please advise here?

@romani
Copy link
Member

romani commented Mar 1, 2024

please add this class to

<allow class="com.puppycrawl.tools.checkstyle.api.SeverityLevel"/>
<allow class="com.puppycrawl.tools.checkstyle.ConfigurationLoader"/>

and disallow AutomaticBean when migration is completed.

@muhlba91 muhlba91 force-pushed the issue/502 branch 6 times, most recently from 5a37b07 to 9f8d2d8 Compare March 1, 2024 17:36
@muhlba91 muhlba91 changed the title Issue #502: update to LTS 9.9; cleanup deprecations WIP Issue #502: update to LTS 9.9; cleanup deprecations Mar 1, 2024
@muhlba91 muhlba91 force-pushed the issue/502 branch 4 times, most recently from 63f1ffe to f69a052 Compare March 1, 2024 18:30
@muhlba91
Copy link
Contributor Author

muhlba91 commented Mar 1, 2024

@romani could you please have a look? 😃

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/9dfe6b2a-d89d-4cd9-b03b-7d7e95436488/jobs/1035 fails because the SQ java plugin is not compatible with java 11 anymore. i have updated the circleci job to use java 17 but this will only be applied once it's in master. (see change https://github.com/checkstyle/sonar-checkstyle/pull/503/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47)

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/878/workflows/996f2d0a-8317-4ffe-9d15-027ecedb0db9/jobs/1037 fails but i don't know the reason, tbh. do you have any ideas here?

@muhlba91 muhlba91 requested a review from romani March 1, 2024 18:40
@romani
Copy link
Member

romani commented Mar 1, 2024

Strange, stable failure.
Restart ci on master is passing https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/860/workflows/cb6568c7-6dff-48ab-8f2e-9604d26c7f8a/jobs/1040

Something is this update

@romani
Copy link
Member

romani commented Mar 2, 2024

Problem is at this step

- attach_workspace:

It might not compatible with docker image for jdk 17, try to remove it or check with git blame why it was added

@muhlba91 muhlba91 force-pushed the issue/502 branch 10 times, most recently from cb30b53 to d151cbb Compare March 2, 2024 08:42
@muhlba91 muhlba91 force-pushed the issue/502 branch 7 times, most recently from 142a90b to a5cde4e Compare March 2, 2024 09:09
Copy link

sonarcloud bot commented Mar 2, 2024

@muhlba91
Copy link
Contributor Author

muhlba91 commented Mar 2, 2024

awesome, thanks! 😃 circleci jobs are running through now and i migrated one of them to github actions as well.

@muhlba91 muhlba91 changed the title WIP Issue #502: update to LTS 9.9; cleanup deprecations Issue #502: update to LTS 9.9; cleanup deprecations Mar 2, 2024
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@muhlba91 muhlba91 merged commit d77b04f into checkstyle:master Mar 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to 9.9 LTS RulePriority deprecated SonarQube 7.6 deprecated org.sonar.api.batch.ScannerSide
2 participants