Fix generate_new_metadata in tidy_backup_clean.rb needs to preserve metadata.json. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasu1105
changed the title
Vasu1105
changed the title
|
@lamont-granquist could you please review this PR. Most of this comments #105 (comment) are incorporated here. |
Vasu1105
force-pushed
the
vasundhara/MSYS_1129_Preserve_metadata_json_in_knife_tidy_backup_clean
branch
from
28e80c7
to
5cf0c2b
Compare
|
@Vasu1105 Can you rebase this please? |
added 4 commits
June 12, 2020 09:17
….rb needs to preserve metadata.json. It skips the new generation of files if both metadata.json and metadata.rb exist It creates minimal data if both metadata.json or metadata.rb does not exist It creates metadata.json if only metadata.rb exist as knife cookbook metadata does. No metadata.rb is generated if only metadata.json exist only fields of the existing metadata.json gets fixed if there any repair to file require which as per old logic. Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
…well when both does not exist Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
Vasu1105
force-pushed
the
vasundhara/MSYS_1129_Preserve_metadata_json_in_knife_tidy_backup_clean
branch
from
da5acb7
to
fe0ce2f
Compare
|
@PrajaktaPurohit this could also use review |
|
@lamont-granquist since you reported this issue do you wanna review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasu1105 vasundhara.jagdale@msystechnologies.com
Description
It skips the new generation of files if both metadata.json and metadata.rb exist
It raises error if both metadata.json or metadata.rb does not exist
It creates metadata.json if only metadata.rb exist as knife cookbook metadata does.
Issues Resolved
Fixes #105
Check List