Skip to content

Comments

fix: return 501 error for phone verification in production#62

Draft
Copilot wants to merge 2 commits intofeature/updatesfrom
copilot/sub-pr-61
Draft

fix: return 501 error for phone verification in production#62
Copilot wants to merge 2 commits intofeature/updatesfrom
copilot/sub-pr-61

Conversation

Copy link

Copilot AI commented Nov 27, 2025

📌 PR Title

fix: return 501 error for phone verification in production


📝 Description

Addresses code review feedback from PR #61. Phone verification was silently succeeding in production without actually sending SMS, creating confusing UX where users receive success messages but never get verification codes.


✅ Changes Made

🔐 Authentication System

  • resend-verification/route.ts: Returns 501 (Not Implemented) for phone verification in production instead of silent success
  • register/route.ts: Same fix for registration flow
if (process.env.NODE_ENV === 'development') {
    console.log(`📱 PHONE VERIFICATION TOKEN for ${phone}:`, token);
} else {
    return NextResponse.json(
        { error: "Phone verification is not yet implemented" },
        { status: 501 }
    );
}

🔍 How to Test

  1. Run npm install to install dependencies
  2. Run npm run dev
  3. Attempt phone verification in development mode (should log token)
  4. In production mode, phone verification should return 501 error

⚡ Additional Notes

  • SMS implementation will be added in a future phase
  • Email verification continues to work normally

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Nov 27, 2025
@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
smart-todo Ready Ready Preview Comment Nov 27, 2025 8:15pm
smart-todo-wum3 Error Error Nov 27, 2025 8:15pm

Co-authored-by: chemist-god <117123746+chemist-god@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 27, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkpoint.prisma.io
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/smart-todo/smart-todo/node_modules/prisma/build/child {&#34;product&#34;:&#34;prisma&#34;,&#34;version&#34;:&#34;6.17.1&#34;,&#34;cli_install_type&#34;:&#34;local&#34;,&#34;information&#34;:&#34;&#34;,&#34;local_timestamp&#34;:&#34;2025-11-27T20:08:57Z&#34;,&#34;project_hash&#34;:&#34;85c6752e&#34;,&#34;cli_path&#34;:&#34;/home/REDACTED/work/smart-todo/smart-todo/node_modules/.bin/prisma&#34;,&#34;cli_path_hash&#34;:&#34;e76bd0cf&#34;, (dns block)
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/smart-todo/smart-todo/node_modules/prisma/build/child {&#34;product&#34;:&#34;prisma&#34;,&#34;version&#34;:&#34;6.17.1&#34;,&#34;cli_install_type&#34;:&#34;local&#34;,&#34;information&#34;:&#34;&#34;,&#34;local_timestamp&#34;:&#34;2025-11-27T20:09:04Z&#34;,&#34;project_hash&#34;:&#34;85c6752e&#34;,&#34;cli_path&#34;:&#34;/home/REDACTED/work/smart-todo/smart-todo/node_modules/.bin/prisma&#34;,&#34;cli_path_hash&#34;:&#34;e76bd0cf&#34;, (dns block)
  • fonts.googleapis.com
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/smart-todo/smart-todo/node_modules/next/dist/compiled/jest-worker/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on feature updates from pull request #61 fix: return 501 error for phone verification in production Nov 27, 2025
Copilot AI requested a review from chemist-god November 27, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants