Skip to content

Fix versioning on PyPI #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbouy merged 3 commits into from
Oct 30, 2025
Merged

Fix versioning on PyPI #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c377113
chore: sync ruff version between pipeline and pyproject specs
cbouy Oct 30, 2025
6ce008f
fix: race condition during cache retrieval
cbouy Oct 30, 2025
54ff621
fix: __version__ metadata
cbouy Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/_build-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
if [[ "${GITHUB_REF}" == refs/tags/* ]]; then
TAG=${GITHUB_REF#refs/*/}
sed -i -e "s/0.0.0/${TAG#v}/" pyproject.toml
echo "Version detected as ${TAG#v}"
fi

- name: Build package
Expand Down Expand Up @@ -74,7 +75,7 @@ jobs:
path: |
dist/prolif-*.whl
dist/prolif-*.tar.gz
key: prolif-${{ runner.os }}-${{ github.sha }}
key: prolif-${{ runner.os }}-${{ github.sha }}-${{ github.ref_type }}

- name: Expose package as artifact
if: inputs.upload-package
Expand Down Expand Up @@ -114,7 +115,7 @@ jobs:
path: |
dist/prolif-*.whl
dist/prolif-*.tar.gz
key: prolif-${{ runner.os }}-${{ github.sha }}
key: prolif-${{ runner.os }}-${{ github.sha }}-${{ github.ref_type }}

- name: Install from tar.gz
run: |
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,22 @@ jobs:
publish:
name: Publish to PyPI
runs-on: ubuntu-latest
needs: [build]
steps:

- name: Retrieve cached package
uses: actions/cache/restore@v3
id: cache-prolif
with:
path: |
dist/prolif-*.whl
dist/prolif-*.tar.gz
key: prolif-${{ runner.os }}-${{ github.sha }}
key: prolif-${{ runner.os }}-${{ github.sha }}-${{ github.ref_type }}
fail-on-cache-miss: true

- name: List output
run: |
ls -lah dist/*

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/formatting_linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Code formatting
uses: astral-sh/ruff-action@v2
with:
version: 0.9.10
version: 0.11.2
args: "format --diff"

- name: Notebook formatting
Expand All @@ -30,5 +30,5 @@ jobs:
- name: Code linting
uses: astral-sh/ruff-action@v2
with:
version: 0.9.10
version: 0.11.2
args: "check --preview --diff"
2 changes: 1 addition & 1 deletion prolif/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import importlib.metadata

try:
__version__ = importlib.metadata.version(__name__)
__version__ = importlib.metadata.version("prolif")
except importlib.metadata.PackageNotFoundError:
__version__ = "0.0.0"
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ type-check = [
"types-networkx",
]
dev = [
"ruff==0.11.2",
"ruff==0.11.2", # keep synced with formatting_linting.yml
"black[jupyter]",
"poethepoet>=0.33.0",
{ include-group = "tests" },
Expand Down
Loading