Fix build errors on gcc-8.1.0

chen3feng · May 29, 2018 · 5f38b62 · 5f38b62
1 parent d0416a3
commit 5f38b62
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/container/bloom_filter_test.cpp b/container/bloom_filter_test.cpp
@@ -27,8 +27,9 @@ TEST(BloomFilter, FalsePositiveRate)
         }
     }
     std::cout << "total_conflicts: " << total_conflicts << "\n";
-    if (total_conflicts > 0)
+    if (total_conflicts > 0) {
         EXPECT_GT(capacity/total_conflicts, 1000) << total_conflicts;
+    }
 }
 
 TEST(BloomFilter, Bitmap)

diff --git a/container/lru_cache_test.cpp b/container/lru_cache_test.cpp
@@ -111,8 +111,9 @@ static void ReadThread(LruCache<int, int> *cache) {
     while (RealtimeClock.MicroSeconds() - now < 500) {
         for (int i = 2; i < 1000; ++i) {
             bool r = cache->Get(i, &value);
-            if (r)
+            if (r) {
                 ASSERT_EQ(0, value % i);
+            }
         }
     }
 }

diff --git a/hash/hash_benchmark.cpp b/hash/hash_benchmark.cpp
@@ -62,7 +62,7 @@ static void MurmurHash64B(int n) {
 
 static void CRC32(int n) {
     for (int i = 0; i < n; i++) {
-        toft::CRC32(test_str);
+        toft::CRC32::Digest(test_str);
     }
 }
 

diff --git a/net/uri/uri.cpp b/net/uri/uri.cpp
@@ -915,7 +915,7 @@ bool URI::WriteToBuffer(char* buffer, size_t buffer_size, size_t* result_size) c
     *result_size = static_cast<size_t>(oss.tellp());
     buffer[*result_size] = '\0';
 
-    return oss;
+    return oss.good();
 }
 
 void URI::Swap(URI* other)

diff --git a/net/uri/uri_test.cpp b/net/uri/uri_test.cpp
@@ -234,8 +234,9 @@ TEST_F(BatchTest, Test)
         {
             bool parse_result = uri.Parse(urls[j]);
             EXPECT_TRUE(parse_result) << urls[j];
-            if (parse_result)
+            if (parse_result) {
                 EXPECT_EQ(urls[j], uri.ToString());
+            }
         }
     }
 }

diff --git a/system/atomic/functions.h b/system/atomic/functions.h
@@ -83,7 +83,8 @@ void EnsureLinkedWithAtomicLibrary();
 template <typename T>
 T AtomicGet(const T* ptr)
 {
-    return __sync_fetch_and_add(const_cast<volatile T*>(ptr), 0);
+    __sync_synchronize();
+    return *ptr;
 }
 
 template <typename T>