Clear invalid JobScheduler data on boot #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unknown reasons, there have been two instances in the wild where Android, at some point, reassigned Custota's app UID. Perhaps something caused Custota's APK to disappear temporarily for one boot? When this happens, the JobScheduler XML file for the old UID gets left behind. While the old job does not show up in `dumpsys jobscheduler`, it still continues to run. This can cause crashes when UpdaterJob is launched with invalid old parameters. This commit works around the problem by deleting JobScheduler XML files with a matching package name, but invalid UID, during boot. Fixes: #116 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
job-scheduler-xml
branch
from
0c34cc9 to
97531d0
Compare
chenxiaolong
added a commit
that referenced
this pull request
Jan 18, 2025
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons, there have been two instances in the wild where Android, at some point, reassigned Custota's app UID. Perhaps something caused Custota's APK to disappear temporarily for one boot?
When this happens, the JobScheduler XML file for the old UID gets left behind. While the old job does not show up in
dumpsys jobscheduler, it still continues to run. This can cause crashes when UpdaterJob is launched with invalid old parameters.This commit works around the problem by deleting JobScheduler XML files with a matching package name, but invalid UID, during boot.
Fixes: #116