Open
Conversation
…tion. Without starting from start index, if the same recipient appears multiple times in the recipient list, this function will crash.
If we're deferring to super.getItem(), then we should be guarding with super.getItemCount().
…stroyed and reference is nullified.
We were getting weird errors around the service not calling startForeground() that I couldn't reproduce. I figure it must be something with how we only sometimes start the FcmFetchService in the foreground. So I think the safest thing to do is to just use GenericForegroundService.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
FREEBIEin my commit messageDescription