Conversation
Closed
ht3064
reviewed
Oct 13, 2025
ht3064
reviewed
Oct 13, 2025
Comment on lines
12
to
13
| @Query("SELECT t FROM TempAlbum t WHERE t.expiredAt = :now") | ||
| List<TempAlbum> findAllExpiredToday(@Param("now") LocalDate now); |
Collaborator
Author
There was a problem hiding this comment.
Prepared Statement 캐싱을 위해서는 파라미터 바인딩이 필요하지 않나요?
Collaborator
There was a problem hiding this comment.
파라미터 이름이 동일해서 어노테이션 제거해도 될 것 같다고 말씀드린겁니다!
ht3064
reviewed
Oct 13, 2025
cherrypic-batch/src/main/java/org/cherrypic/domain/tempalbum/service/TempAlbumService.java
Show resolved
Hide resolved
ht3064
reviewed
Oct 13, 2025
cherrypic-infrastructure/src/main/java/org/cherrypic/s3/S3Util.java
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항