- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 99
Respond 400 instead of 500 when first header field line starts with SP or HTAB #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bd642f1    to
    3fa1439      
    Compare
  
    | Codecov ReportAll modified and coverable lines are covered by tests β 
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   83.65%   83.67%   +0.02%     
==========================================
  Files          28       28              
  Lines        4166     4178      +12     
==========================================
+ Hits         3485     3496      +11     
- Misses        681      682       +1      | 
94d81bb    to
    6778ce9      
    Compare
  
    Prevent unhandled exception in header parsing that results in 500 responses when the first received header begins with whitespace.
for more information, see https://pre-commit.ci
| "Bad chunked transfer size: {chunk_size!r}".format( | ||
| chunk_size=chunk_size | ||
| 'Bad chunked transfer size: {chunk_size!r}'.format( | ||
| chunk_size=chunk_size, | 
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| r"https://github\.com" | ||
| r"/python/cpython/blob/c39b52f/Lib/poplib\.py#user-content-L297-L302", | ||
| r"^https://matrix\.to/#", # these render fully on front-end from anchors | ||
| r'https://github\.com' r'/python/cpython/blob/c39b52f/Lib/poplib\.py#L297-L302', | 
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning documentation
| r'https://github\.com' | ||
| r'/python/cpython/blob/c39b52f/Lib/poplib\.py#user-content-L297-L302', | 
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning documentation
β What kind of change does this PR introduce?
π What is the related issue number (starting with
#)#728
β What is the current behavior? (You can also link to an open issue here)
Cheroot responds 500 when it receives a request in which the first header field line starts with SP or HTAB, due to an
UnboundLocalError.β What is the new behavior (if this is a feature change)?
It responds 400 instead.
π Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change isβ