Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowering recall threshold #912

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

scicco
Copy link

@scicco scicco commented Sep 16, 2024

Description

This is my first attempt to try to contribute a bit to this awesome project😹
This commit will lower the recall threshold. It also separates the config introducing the RecallSettings class as suggested in TODO

I've set the following constant values:

    DEFAULT_K = 3
    DEFAULT_TRESHOLD = 0.5

please let me know if those values are appropriate.

Related to issue (#909)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@valentimarco
Copy link
Collaborator

Thx for the contribution! For me is ok but i would prefer to have a central module to store all classes like this one. What do you think @pieroit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants