Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit attempts to clean old strays after some time. Currently, the expiration check is accomplished every time a new connection is made.
Related to issue #846
How to test this
test<n>
wheren
means the amount of minutes before expiration if no new connection is performedtest<n>
on a tabn
minutesadmin
on another tabtest<n>
tab: the previous "session " oftest<n>
should be cleaned (the chat history should be empty)What is missing
Currently, the cleanup and the refresh of sessions happen only when a new connection is done. We need also to refresh the expiration when a user's message arrives. I need some guidance to understand where is the right place to invoke refresh on the code, I think the call should go in some line of
core/core/cat/looking_glass/stray_cat.py
Line 322 in f14f2c0
Type of change
Checklist: