Skip to content

Support Python 3.12#370

Merged
chezou merged 1 commit intomasterfrom
py312
Nov 20, 2023
Merged

Support Python 3.12#370
chezou merged 1 commit intomasterfrom
py312

Conversation

@chezou
Copy link
Copy Markdown
Owner

@chezou chezou commented Nov 19, 2023

Description

Close #368

Note that jpype doesn't support Python 3.12 yet, the tabula-py unit test runs without jpype on Python 3.12.

Motivation and Context

To support Python 3.12 without waiting jpype supports.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou
Copy link
Copy Markdown
Owner Author

chezou commented Nov 20, 2023

hmmm, Windows test hits this issue actions/runner#2451

@chezou
Copy link
Copy Markdown
Owner Author

chezou commented Nov 20, 2023

The above issue should be resolved by #371

@chezou chezou merged commit cefa1f4 into master Nov 20, 2023
@chezou chezou deleted the py312 branch November 20, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.12

1 participant