Overall update #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 15, 2018 17:50
mjyc
force-pushed
the
update-test
branch
2 times, most recently
from
6554df6 to
48bea13
Compare
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chfritz !
I finally had sometime to update this package, and I hope to have it merge to the original repo.
This PR updates the most code in the pkg to update the pkg to make it compatible with newer meteor and rosnodejs. Also overall robustness is improved.
Please run
to see changes made in action.
This PR was tested with meteor 1.6. Note that practicalmeteor: mocha pkg was not working in meteor >= 1.6, see practicalmeteor/meteor-mocha#100.