fix(gui): reduce choice builder full-reload usage

[chhoumann]

Reduce remaining full modal reload usage in shared ChoiceBuilder open-file controls by rerendering only the file-opening section in place.

This is phase 4 of the FSM/reload stabilization stream after #1132, #1133, #1134, and #1135.

What changed:

• ChoiceBuilder
  • addOpenFileSetting now supports context-aware in-place section updates
  • introduced local section container choiceBuilder__fileOpeningSection
  • open toggle and file-opening location changes rerender only that section
  • legacy fallback remains: when context is not provided, existing reload behavior is unchanged
• TemplateChoiceBuilder and CaptureChoiceBuilder
  • switched to shared context-aware call: addOpenFileSetting(..., "created" / "captured")
  • removed duplicate conditional call pattern that depended on full modal reload
• updated living ExecPlan with phase-4 progress, decisions, and evidence

Why:

• open-file and location controls are high-frequency pivots that only affect a narrow subsection of UI.
• rerendering only that section reduces modal churn and preserves user editing context more naturally.

Validation:

• bun run test
• bun run build-with-lint
• Obsidian CLI smoke in dev vault:
  • obsidian vault=dev plugin:reload id=quickadd
  • obsidian vault=dev command id=quickadd:testQuickAdd
  • obsidian vault=dev dev:errors (no runtime errors)

Refs #1130

---

Summary by CodeRabbit

• Improvements
  • Enhanced file-opening settings rendering to eliminate unnecessary full modal reloads when toggling open-file options or changing file-opening locations in template and capture builders. File-opening settings now update in place for immediate feedback, providing a faster and more responsive experience when configuring file behavior.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quickadd	Ready	Preview	Mar 5, 2026 7:12am

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR implements context-aware in-place rendering for file-opening settings in ChoiceBuilder and its subclasses. The addOpenFileSetting method now accepts an optional contextLabel parameter; when provided, toggling the open-file option triggers a localized re-render instead of a full modal reload, maintaining backward compatibility with the original reload behavior when no context label is supplied.

Changes

Cohort / File(s)	Summary
Planning Documentation plans/issue-1130-fsm-modal-reload.md	Documents phase-4 migration approach for shared in-place rendering and generalized context-aware rendering via ChoiceBuilder.
Core Rendering Logic src/gui/ChoiceBuilder/choiceBuilder.ts	Extends addOpenFileSetting with optional contextLabel parameter; adds private state field fileOpeningSectionContainer, and new private methods renderFileOpeningSection and addFileOpeningSettingsToContainer to support conditional in-place re-rendering instead of reload when context is provided.
Subclass Implementations src/gui/ChoiceBuilder/captureChoiceBuilder.ts, src/gui/ChoiceBuilder/templateChoiceBuilder.ts	Updates call sites to pass target/context parameter ("captured" and "created" respectively) to addOpenFileSetting, replacing conditional logic that previously only added the setting when choice.openFile was true.

Possibly related PRs

• fix(gui): preserve modal edit position during settings reload #1132: Related — both PRs modify src/gui/ChoiceBuilder/choiceBuilder.ts and directly alter ChoiceBuilder's rendering and reload lifecycle behavior (this PR adds context-aware in-place rendering; the other introduces ModalReloadController).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hopping through choice-builders with glee,
No reloads to slow us down, you'll see!
Context-aware renders in place,
Make the UI keep up its pace! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: reducing full-reload usage in the choice builder by implementing in-place section rerendering for file-opening controls.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fsm-phase4-reduce-choicebuilder-reloads

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying quickadd with    Cloudflare Pages

Latest commit:	7c7cc51
Status:	✅  Deploy successful!
Preview URL:	https://942dbe94.quickadd.pages.dev
Branch Preview URL:	https://fsm-phase4-reduce-choicebuil.quickadd.pages.dev

View logs

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

[coderabbitai]

🧹 Nitpick comments (1)

src/gui/ChoiceBuilder/choiceBuilder.ts (1)

30-37: Clear stale file-opening container references on fallback/full-render paths.

fileOpeningSectionContainer can retain a detached element reference across redraw branches. Resetting it explicitly makes section-mode detection safer for future call paths.

♻️ Suggested hardening

 		this.reloadController = new ModalReloadController({
 			modalEl: this.modalEl,
 			contentEl: this.contentEl,
 			render: () => {
+				this.fileOpeningSectionContainer = null;
 				this.contentEl.empty();
 				this.display();
 			},
 		});
@@
-		if (!contextLabel) return;
+		if (!contextLabel) {
+			this.fileOpeningSectionContainer = null;
+			return;
+		}

Also applies to: 139-143

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/gui/ChoiceBuilder/choiceBuilder.ts` around lines 30 - 37, The
fileOpeningSectionContainer reference can persist a detached DOM node across
redraw branches; update the ModalReloadController render callback (where
reloadController is created) and the other fallback/full-render paths (the
branches around the display logic referenced at lines ~139-143) to explicitly
null/clear fileOpeningSectionContainer before repopulating the UI: inside the
render: () => { ... } and in the fallback/full-render branches set
this.fileOpeningSectionContainer = null (or empty container) prior to calling
this.contentEl.empty() / this.display() so section-mode detection always sees a
fresh container reference.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/gui/ChoiceBuilder/choiceBuilder.ts`:
- Around line 30-37: The fileOpeningSectionContainer reference can persist a
detached DOM node across redraw branches; update the ModalReloadController
render callback (where reloadController is created) and the other
fallback/full-render paths (the branches around the display logic referenced at
lines ~139-143) to explicitly null/clear fileOpeningSectionContainer before
repopulating the UI: inside the render: () => { ... } and in the
fallback/full-render branches set this.fileOpeningSectionContainer = null (or
empty container) prior to calling this.contentEl.empty() / this.display() so
section-mode detection always sees a fresh container reference.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46b5caf5-10ba-41a1-8d32-f3e0718eb2dd

📥 Commits

Reviewing files that changed from the base of the PR and between a1a6271 and 7c7cc51.

📒 Files selected for processing (4)

• plans/issue-1130-fsm-modal-reload.md
• src/gui/ChoiceBuilder/captureChoiceBuilder.ts
• src/gui/ChoiceBuilder/choiceBuilder.ts
• src/gui/ChoiceBuilder/templateChoiceBuilder.ts

[github-actions]

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀