Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate dictionary lookup #4

Merged

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@jolexxa
Copy link
Member

jolexxa commented Jun 12, 2024

Thank you for all the help, and super fast too!

Your PR's can't run in CI because I am probably passing in an unnecessary token here:

token: ${{ secrets.GH_BASIC }}

I'll try and make a PR to remove that later today so we can get these updated and run.

@SimonCropp
Copy link
Contributor Author

@definitelyokay if it is easier, you can make the change yourself and test local. i dont need the credit for a merged PR

@jolexxa jolexxa merged commit d0e9d5f into chickensoft-games:main Jul 20, 2024
1 of 2 checks passed
@SimonCropp SimonCropp deleted the remove-duplicate-dictionary-lookup branch July 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants