Skip to content

Commit

Permalink
performance improvement to reduce unnecessary refreshes
Browse files Browse the repository at this point in the history
sometimes, the "successfully saved" text can disappear while waiting
for the loading circle to disappear

with the new waiting method, checking the loading circle should
be redundant
  • Loading branch information
ndepaola committed Aug 6, 2024
1 parent 020cc49 commit f2e265b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions desktop-tool/src/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -646,9 +646,8 @@ def save_project_to_user_account(self, order: CardOrder) -> None:
project_name_element.send_keys(project_name)
self.wait_until_javascript_object_is_defined("oDesign.setTemporarySave")
self.execute_javascript("oDesign.setTemporarySave();")
self.wait()

wait_timeout_seconds = 15
wait_timeout_seconds = 30
try:
WebDriverWait(self.driver, wait_timeout_seconds).until(
text_to_be_present_in_element(
Expand Down

0 comments on commit f2e265b

Please sign in to comment.