Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home route URI containing leading slash #80

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

fyrts
Copy link
Contributor

@fyrts fyrts commented Feb 22, 2024

Some third party packages (for example Ziggy, which is used by Breeze) have issues with the prefixed home URI containing a leading slash. This results in the home URL being rendered as http://localhost//en instead of http://localhost/en. Considering that Laravel's own Router removes leading slashes from URI's, I thought it might be appropriate to remove it here as well.

@fyrts fyrts marked this pull request as ready for review February 22, 2024 16:57
@chinleung chinleung merged commit 58e21bc into chinleung:v4 Feb 26, 2024
3 of 4 checks passed
@chinleung
Copy link
Owner

Thanks for the contribution @fyrts! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants