User iterator instead of temporary buffer for CertifyKey TCB #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhand2
changed the title
zhalvorsen
previously approved these changes
Oct 11, 2024
zhalvorsen
reviewed
Oct 11, 2024
When encoding TcbInfos, do not make a temporary buffer to copy all the TCI measurements. This adds multiple KiB of stack usage. Instead, add a function to allow the X.509 library to create an iterator for the TCB of the node. This allows the main DPE context array to be used as the backing memory when encoding TcbInfos instead of using extra stack space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encoding TcbInfos, do not make a temporary buffer to copy all the
TCI measurements. This adds multiple KiB of stack usage. Instead, add a
function to allow the X.509 library to create an iterator for the TCB of
the node.
This allows the main DPE context array to be used as the backing memory
when encoding TcbInfos instead of using extra stack space.
This reduces stack usage by ~350 bytes