Use feature of bazel to disable warnings in 3rd party code. #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These warnings are not actionable, so this will output more relevant warnings. Unfortunately, bazel5 does not understand that yet, it is only a feature in bazel6 and above. Does not fix yet the issue in question as we can't enable it quite yet in the toplevel .bazelrc, so only referencing Issue chipsalliance#747
|
Ah well, can't enable that quite yet as we still use bazel 5 in the CI to make sure we're backward compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warnings are not actionable, so this will output more relevant warnings.
Unfortunately, bazel5 does not understand that yet, it is only a feature in bazel6 and above.
Does not fix yet the issue in question as we can't enable it quite yet in the toplevel .bazelrc, so only referencing
Issue #747