Skip to content

Fix documentation for Install-ChocolateyZipPackage output #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Fix documentation for Install-ChocolateyZipPackage output #2357

merged 1 commit into from
May 30, 2025

Conversation

Ana06
Copy link
Contributor

@Ana06 Ana06 commented Sep 17, 2021

Install-ChocolateyZipPackage calls Get-ChocolateyUnzip which outputs
the passed in $destination. Consequently, Install-ChocolateyZipPackage
outputs the passed in $unzipLocation.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ana06
Copy link
Contributor Author

Ana06 commented Sep 17, 2021 •
edited
Loading

Is it needed to sign the CLA for this? I think this can be considered a trivial change.

Ensure you have signed the Contributor License Agreement (CLA) - without this we are not able to take contributions that are not trivial.

@gep13
Copy link
Member

gep13 commented May 15, 2025

This PR will need to be rebased and re-targetted to the develop branch.

@gep13 gep13 marked this pull request as draft May 15, 2025 13:50
@vexx32 vexx32 mentioned this pull request May 16, 2025
Open
44 tasks
@Ana06 @gep13
(maint) Fix Install-ChocolateyZipPackage outputs
2dfed70 
`Install-ChocolateyZipPackage` calls `Get-ChocolateyUnzip` which outputs
the passed in `$destination`. Consequently, `Install-ChocolateyZipPackage`
outputs the passed in `$unzipLocation`.
@gep13 gep13 changed the base branch from master to develop May 30, 2025 15:01
@gep13
Copy link
Member

gep13 commented May 30, 2025

@Ana06 said...
Is it needed to sign the CLA for this? I think this can be considered a trivial change.

No, this is not required for this change.

Please accept my apologies for only getting to this now. Around here, the wheels do turn, but they turn slowly. Going to get this change merged once the CI builds complete.

Thank you for your contribution here!

@gep13 gep13 marked this pull request as ready for review May 30, 2025 15:03
gep13
gep13 approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 added this to the 2.5.0 milestone May 30, 2025
@gep13 gep13 changed the title (maint) Fix Install-ChocolateyZipPackage outputs Fix documentation for Install-ChocolateyZipPackage output May 30, 2025
@gep13 gep13 merged commit 659f5d3 into chocolatey:develop May 30, 2025
4 of 5 checks passed
@gep13
Copy link
Member

gep13 commented May 30, 2025

@Ana06 thanks again for doing this! This will ship as part of Chocolatey CLI 2.5.0.

@AdmiringWorm AdmiringWorm mentioned this pull request Jun 3, 2025
Merged
10 tasks
@gep13 gep13 added the 4 - Done label Jun 5, 2025
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
5 - Released Documentation
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Ana06 @CLAassistant @gep13 @choco-bot