Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add explicit deletion to contexts in ContextCache on empty #690

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Apr 20, 2023

Description

Note: this may not be sufficient; will need to investigate that it
actually succeeds in clearing contexts.

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message


Note: this may not be sufficient; will need to investigate that it
actually succeeds in clearing contexts.
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #690 (49f2e1d) into main (b379af3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@dotsdl
Copy link
Member Author

dotsdl commented Apr 22, 2023

This may not be finished yet; please do not merge.

@dotsdl dotsdl changed the title Add explicit deletion to contexts in ContextCache on empty [WIP] Add explicit deletion to contexts in ContextCache on empty Apr 22, 2023
@jchodera
Copy link
Member

This should address #688

@ijpulidos
Copy link
Contributor

ijpulidos commented May 25, 2023

We want to write tests that creates many context caches and make sure that the resources of the GPU don't get depleted (if we are emptying the context cache correctly). First we test this locally and then in the GPU CI.

We need GPU CI testing for this.

@ijpulidos
Copy link
Contributor

After the basic test we can also create a replica exchange sampler test where we create and destroy many repex samplers and check if the GPU resources are correctly handled.

Minimizers might be creating their own context. We can give it a pre-minimized structure or tell it to do only one minimization step (using the multistatesampler minimize method)

@jchodera
Copy link
Member

We also need a __del__ that calls empty().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants