Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop older python version #714

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Drop older python version #714

merged 3 commits into from
Nov 6, 2023

Conversation

mikemhenry
Copy link
Contributor

Description

We can drop python 3.8 testing per NEP 29

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message


@mikemhenry
Copy link
Contributor Author

I added 3.11, if we have issues with solving we can remove it before merge.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #714 (145ef0b) into main (6cef59b) will not change coverage.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

Looks like nose is unhappy

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@mikemhenry
Copy link
Contributor Author

We can fix nose + py311 later

@mikemhenry
Copy link
Contributor Author

If 3.11 works we will close this pr and merge in this one #702 if 3.11 doesn't work, I will merge in this pr and close 702

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikemhenry mikemhenry enabled auto-merge (squash) November 6, 2023 22:00
@mikemhenry mikemhenry merged commit 0b4d42a into main Nov 6, 2023
10 checks passed
@mikemhenry mikemhenry deleted the mikemhenry-patch-4 branch November 6, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants