-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HIP platform to openmmtools #753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks good to me. We do need to add tests for the HIP to our GPU CI, but I don't think that's a blocker now. It's a good idea to let users start playing with this platform, imo. Thanks!
Since we have the openmm 8.2.0 rc in conda-forge should we test this PR with that rc? At least temporarily to run the CI with it. Maybe we actually need a workflow that runs CI with rc in general. |
Now that 8.2 is out, we can just double check things pass and 8.2 is pulled in EDIT: Forgot we are explicit about the openmm versions we test |
I've added 8.2.0 to the testing matrix and removed older openmm versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
We need to write the tests to properly validate the platform but this is a great starting point.
Description
Provide a brief description of the PR's purpose here.
Todos
Status
Changelog message