Skip to content

Conversation

@MohaElder
Copy link

  1. It seems that in newer versions of React(e.g: 18.x.x), you need to use PropsWithChildren to wrap your function or else there will be Property 'children' does not exist on type 'IntrinsicAttributes & Props' error.

reference: Answer from StackOverflow

  1. I noticed that there are missing prop type definitions in Marker (title & subtitle) and Map (tintColor). I have added them.

@MohaElder
Copy link
Author

Hi! I saw your comment on this closed PR that explained why you don't want to upgrade library's React related specifications to ensure its compatibility with older React versions. But I was wondering if it is possible to have a seperate version of this library that supports newer react versions since the current library crashes on newer react versions. If possible, I could help with that! Thanks for the time reading this~

@chrisdrackett
Copy link
Owner

I think this library could probably be updates to both not crash and work on older react versions :D

I plan on circling back to this library soon as I need it for an upcoming project. In the meantime I'm happy to accept PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants