Skip to content

Fix the disappearing controller issue when opening the queue from sidebar#502

Open
bananasss00 wants to merge 4 commits intochrisgoringe:1.8from
bananasss00:1.8
Open

Fix the disappearing controller issue when opening the queue from sidebar#502
bananasss00 wants to merge 4 commits intochrisgoringe:1.8from
bananasss00:1.8

Conversation

@bananasss00
Copy link

… sidebar or node library and etc.

2025-02-24.14-52-46.mp4

I'm not very fond of this fix; maybe you can come up with a better solution

@bananasss00
Copy link
Author

{1637D5AB-F27A-4DE9-B21A-857EACD6C2F4}
problematic fix got when there are several panels in a workflow, they stack on top of each other!

@JorgeR81
Copy link

JorgeR81 commented Feb 24, 2025

This issue may be related to other issues.
For me, the Controller also disappears when we open or switch any Sidebar.
This did not happen before.

The Controller also disappears when we enter focus mode ( hiding TopBar and Sidebar ) ( #500 ).

And when we open a new workflow there is a similar problem ( #498 ).
The first time we "toggle on" the controller, it does not show up, but the Top Bar button it's "on" ( blue ).

@JorgeR81
Copy link

I did some more testing.

All the bugs mentioned above, seem to be caused by frontend version 1.8.2
https://github.com/Comfy-Org/ComfyUI_frontend/releases/tag/v1.8.2


Using frontend 1.8.1, everything works fine.

--front-end-version Comfy-Org/ComfyUI_frontend@v1.8.1

@JorgeR81
Copy link

By the way @bananasss00, what's that purple outline in the group buttons, in your images?
You also have it in previous images ( #486 (comment) ).

There's a feature with a similar visual effect ( #448 ), but it's not implemented yet.

@bananasss00
Copy link
Author

By the way @bananasss00, what's that purple outline in the group buttons, in your images?

This effect occurs when these nodes are enabled
https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet

@JorgeR81
Copy link

By the way @bananasss00, what's that purple outline in the group buttons, in your images?

This effect occurs when these nodes are enabled
https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet

Ah, ... that extension has similar buttons, with thick outlines ( e.g. painter node ).
So maybe that's interfering with the Controller's button code.
In the Controller, normal behavior it's simply for the selected button to be brighter.

g1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants