Updated tika to use sha1 hash instead of md5 for checksum #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @griffin-rickle let me take a look. Is there a way to do this in a back compat way (see my comments on #348 ) |
Not sure if you saw my comment on the original Issue thread, but this has been done. Let me know if there's anything else I could do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHA1 has been deprecated in FIPS and there are suggested steps to move away from the algorithm, but it is still supported for "Non-digital-signature applications" (CTRL-F for SHA-1 to find the supported usages table in the PDF). The maven repository supplying the Tika JAR only provides md5 and sha1 checksums, or an .asc file for verifying the signature of the file (which is not the same as verifying the checksum), so I have implemented and update to use sha1 instead of md5.