Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #44 (touch event for mobile) #53

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tgmof
Copy link

@tgmof tgmof commented Jan 1, 2021

Adding the touch event behaviour
Aligning it with the click event (focus, defocus and quick tooltip appearance)

@mledwards
Copy link

This is working great! Can it be merged in?

@mledwards
Copy link

mledwards commented Mar 3, 2021

I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.

This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head

@halfgian
Copy link

halfgian commented Jun 4, 2021

Can this be merged? It is super useful. @chrisrzhou

@tgmof
Copy link
Author

tgmof commented Jun 4, 2021

@mledwards

I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.

This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head

No idea, but indeed I never succeeded to run that directly in another project, I always used it as an external package and referencing it this way (manually) in the package.json:
https://github.com/tgmof/me/blob/master/package.json#L16 (with a different link to match this PR only)
Before running a sync to fetch all required packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants