Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #23

Merged
merged 16 commits into from
Aug 26, 2023
Merged

Tests #23

merged 16 commits into from
Aug 26, 2023

Conversation

christianonoh
Copy link
Owner

Hi @Ellyboi,

Description:

This pull request addresses the following:

  1. Tests: I have implemented RSpec tests for the User, Course, and Reservation models to ensure they meet the defined validations.

  2. Factories: I have set up factories using FactoryBot for both Course and User models. These factories are used in the test suite to create test data.

  3. Controllers: I have written request tests for the CourseController and ReservationController to verify the behavior of these controllers' actions.

  4. Model Validations: I have added validations to the User, Course, and Reservation models to ensure data integrity.

  5. Coverage: All tests pass successfully, providing good test coverage for both models and controllers.

Changes Made:

  • Added validations to the User, Course, and Reservation models to ensure data consistency.
  • Set up FactoryBot factories for creating test data.
  • Wrote RSpec tests for the User, Course, and Reservation models.
  • Wrote RSpec request tests for the CourseController and ReservationController.

Copy link
Collaborator

@Ellyboi Ellyboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED 🟢
Congratulations, you project is complete, merge it 💌

@christianonoh christianonoh merged commit f32d7bb into dev Aug 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants