-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #23
Merged
Merged
Tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ellyboi
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED 🟢
Congratulations, you project is complete, merge it 💌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Ellyboi,
Description:
This pull request addresses the following:
Tests: I have implemented RSpec tests for the
User
,Course
, andReservation
models to ensure they meet the defined validations.Factories: I have set up factories using FactoryBot for both
Course
andUser
models. These factories are used in the test suite to create test data.Controllers: I have written request tests for the
CourseController
andReservationController
to verify the behavior of these controllers' actions.Model Validations: I have added validations to the
User
,Course
, andReservation
models to ensure data integrity.Coverage: All tests pass successfully, providing good test coverage for both models and controllers.
Changes Made:
User
,Course
, andReservation
models to ensure data consistency.User
,Course
, andReservation
models.CourseController
andReservationController
.