-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
## Pull Request: Add Initial Backend Features (API v1) for Vecs School #26
Conversation
Setup Rails app
Reservations
API Documentation Using Rswag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christianonoh,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Nice code organization ✔️
- App is working well✔️
- Good readme ✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
README.md
Outdated
```sh | ||
rails db:create | ||
rails db:migrate | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You have a very functional
seeds.rb
. Kindly add to your db commandsrails db:seed
.
That way, your users will enjoy a pre-seeded database. 👍
README.md
Outdated
- **Run Tests:** Use the following command to run the tests. | ||
```sh | ||
rspec | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I run your tests according to your instructions, this happens:
This is because all your request tests are swagger tests. Rspec won't run them properly.
Therefore, kindly be more specific in your instructions so your users never get a failing test:
rspec ./spec/models
rspec ./spec/controllers
Result:
That way, your users will never get a failing test 👍
README.md
Outdated
|
||
- **Run Tests:** Use the following command to run the tests. | ||
```sh | ||
rspec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You are using Rspec, but the "test" folder still exists, which is used by another test framework. Kindly consider deleting that folder if you are not using it. 👍
Thank you taking your time to give this acceptable criticism......The corrections will immediately be implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christianonoh,
Wow, you did it 🎉
Thank you for the changes implemented 💪 🥇 ㊗️
Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩
You are about to finish the Microverse program. You have come a long way!!!
Good luck in the software industry!! I'll see you there. ✨
Congratulations!!!!!! 🎉
To highlight
- Superfluous test folder has been removed✔️
- db seeding instructions have been included✔️
- Tests instructions have been improved ✔️
- Great job✔️
Cheers and Happy coding!👏👏👏
Description:
This pull request introduces the first version (v1) of the Vecs School backend API, encompassing fundamental features for managing courses, reservations, user registration, authentication, and user-specific operations.
Link to frontend application - VECS School Frontend
Features Added:
Endpoints for Courses (API v1):
Endpoints for Reservations (API v1):
User Authentication and Authorization:
Endpoint for Current Logged-In User:
Testing and Documentation:
Changes Made:
API Routes (API v1):
POST /signup
- Register a new user.POST /login
- Authenticate and receive an access token.DELETE /logout
- Log out the current user.GET /api/v1/courses
- Retrieve a list of all courses.GET /api/v1/courses/:id
- Retrieve details of a specific course.POST /api/v1/courses
- Create a new course.PUT /api/v1/courses/:id
- Update details of a course.DELETE /api/v1/courses/:id
- Delete a course.GET /api/v1/reservations
- Retrieve a list of all reservations.GET /api/v1/reservations/:id
- Retrieve details of a specific reservation.POST /api/v1/reservations
- Create a new reservation.GET /api/v1/current_user
- Retrieve details of the current logged-in user.Reviewer:
Kindly review this pull request to ensure adherence to coding standards, security practices, and overall code quality.
Thank you for your time and consideration.
Best regards,
@christianonoh, @smunoz1988, @Ellyboi and @vvoo21