Merge pull request #79 from ubwhole/application_proxy

Update is_valid_signature() to support proxied requests from Shopify
christophergregory · Jul 17, 2017 · 8d7d74e · 8d7d74e
2 parents 44fd5d3 + 92075cd
commit 8d7d74e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/shopify.js b/lib/shopify.js
@@ -52,6 +52,7 @@ ShopifyAPI.prototype.is_valid_signature = function(params, non_state) {
     }
 
     var hmac = params['hmac'],
+        theHash = params['hmac'] || params['signature'],
         secret = this.config.shopify_shared_secret,
         parameters = [],
         digest,
@@ -63,14 +64,14 @@ ShopifyAPI.prototype.is_valid_signature = function(params, non_state) {
         }
     }
 
-    message = parameters.sort().join('&');
+    message = parameters.sort().join(hmac ? '&' : '');
 
     digest = crypto
                 .createHmac('SHA256', secret)
                 .update(message)
                 .digest('hex');
 
-    return (digest === hmac);
+    return ( digest === theHash );
 };
 
 ShopifyAPI.prototype.exchange_temporary_token = function(query_params, callback) {