Harden unsafe unwraps, validate temporal bounds, and refresh README#47
Open
christopherkarani wants to merge 1 commit intomainfrom
Open
Harden unsafe unwraps, validate temporal bounds, and refresh README#47christopherkarani wants to merge 1 commit intomainfrom
christopherkarani wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
READMEquick-start.Description
MetalVectorEngine.searchwith a guardedwithUnsafeBytesunwrap and removed a forced pipeline unwrap by selecting the active pipeline with explicit optional binding inSources/WaxVectorSearch/MetalVectorEngine.swift.guard ... toMs! > ...style checks with safeif letvalidations forvalid.toMsandsystem.toMsinSources/WaxTextSearch/FTS5SearchEngine.swiftto avoid force-unwrapping temporal bounds.Sources/WaxVectorSearchMiniLM/CoreML/all-MiniLM-L6-v2.swiftby guarding the model output lookup and bundle URL lookup and emitting clearfatalErrormessages instead of force-unwrapping optional values.README.mdto present a one-line purpose, a visible quick-start example, SPM install snippet, clear capability list, and when-to-use guidance for production onboarding.Testing
swift test --filter WaxCoreTests --filter WaxIntegrationTests/READMEExamplesTests, but the invocation failed early due to an existing package manifest issue:error: 'wax': invalid custom path 'Tests/WaxTests' for target 'waxTests'(this is a pre-existing project config problem and blocked running the full test suite).MetalVectorEngine.swift,FTS5SearchEngine.swift,all-MiniLM-L6-v2.swift, andREADME.md.Codex Task