feat: Add initial type hints for RedisSession#42
Draft
riton wants to merge 1 commit intochristopherpickering:devfrom
Draft
feat: Add initial type hints for RedisSession#42riton wants to merge 1 commit intochristopherpickering:devfrom
riton wants to merge 1 commit intochristopherpickering:devfrom
Conversation
Author
|
I can see that the original project has been adopted by Pallets Community and that you're trying to merge back your modifications into original project. Nice move 👍 👏 I should reopen this P.R against original project, don't you think ? |
Owner
|
hey @riton thanks for this, sorry I missed it! You could pr the original project as well. I don't use this anymore and probably won't be helping much there... it seems like some people just wanted that project updated for the latest flask but don't care about other fixes/improvements. This looks good, you can undraft it and I will merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for providing a maintained alternative to the
flask-sessionproject 👍This P.R is a proposal for type hinting this project.
I've currently only added type hints to the
Redissession implementation.I wanted to initiate a discussion with you before going further on that path.
Regards