Skip to content

Comments

feat: Add initial type hints for RedisSession#42

Draft
riton wants to merge 1 commit intochristopherpickering:devfrom
ccin2p3:feature/type_hints
Draft

feat: Add initial type hints for RedisSession#42
riton wants to merge 1 commit intochristopherpickering:devfrom
ccin2p3:feature/type_hints

Conversation

@riton
Copy link

@riton riton commented May 4, 2023

First of all, thanks for providing a maintained alternative to the flask-session project 👍

This P.R is a proposal for type hinting this project.

I've currently only added type hints to the Redis session implementation.

I wanted to initiate a discussion with you before going further on that path.

Regards

@riton riton force-pushed the feature/type_hints branch from 79117d1 to 1dba54c Compare May 4, 2023 14:49
@riton riton force-pushed the feature/type_hints branch from 1dba54c to 0f0b83d Compare May 4, 2023 14:52
@riton
Copy link
Author

riton commented May 10, 2023

I can see that the original project has been adopted by Pallets Community and that you're trying to merge back your modifications into original project. Nice move 👍 👏

I should reopen this P.R against original project, don't you think ?

@christopherpickering
Copy link
Owner

hey @riton thanks for this, sorry I missed it!

You could pr the original project as well. I don't use this anymore and probably won't be helping much there... it seems like some people just wanted that project updated for the latest flask but don't care about other fixes/improvements.

This looks good, you can undraft it and I will merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants