Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Record insertion time/count for wal3 dirty log. #4050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Mar 21, 2025

This makes the wal3 dirty log record information that may be useful for
determining which collections to compact or defer.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch from c84aff5 to a758344 Compare March 22, 2025 00:27
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from 9dd82fe to 00cbffa Compare March 23, 2025 22:33
@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch from a758344 to cc58475 Compare March 23, 2025 22:34
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from 00cbffa to bd1e289 Compare March 24, 2025 17:49
@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch from cc58475 to ead67f2 Compare March 24, 2025 17:50
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from bd1e289 to fd2fbbd Compare March 24, 2025 19:53
@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch 2 times, most recently from e04661b to e4f6537 Compare March 24, 2025 20:09
@rescrv rescrv requested review from sanketkedia and HammadB March 24, 2025 23:47
@rescrv rescrv force-pushed the rescrv/wal3-cleanup branch from 024fee9 to 504f581 Compare March 27, 2025 22:14
@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch 2 times, most recently from 4910550 to 4d71aa8 Compare March 28, 2025 19:33
@rescrv rescrv changed the base branch from rescrv/wal3-cleanup to main March 28, 2025 19:51
This makes the wal3 dirty log record information that may be useful for
determining which collections to compact or defer.
@rescrv rescrv force-pushed the rescrv/wal3-dirty-meta branch from 4d71aa8 to b74c7ab Compare March 31, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants