-
Notifications
You must be signed in to change notification settings - Fork 2k
[DOC] Fix doc 500 due to tabs component #5989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fix doc 500 due to tabs component #5989
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Handle single-child tabs and adjust language fallback Updates the Markdoc Key Changes• Normalize Affected Areas• docs/docs.trychroma.com/components/markdoc/tabs.tsx This summary was automatically generated by @propel-code-bot |

We're getting 500s on several pages because the Tab markdoc component only has one child. This PR prevents the Tab component from breaking when it only has one child.
https://docs.trychroma.com/integrations/embedding-models/text2vec
https://docs.trychroma.com/integrations/embedding-models/nomic
https://docs.trychroma.com/integrations/embedding-models/open-clip
Additionally, this changes the persistent language behavior for tabs. Before, if you chose "Typescript" and then went on this page where there is no Typescript option, it would simply have no tab selected and show nothing.
Now, if the preferred tab is not available, it will default to the first tab option. This is at the cost of the tabs not updating to your new preferred language while you're on the page -- only when you change pages.