Skip to content

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 10, 2025

Description of changes

This allows us to, for example, set the dirty log writer's fragment
write interval to 1s so that the dirty log won't flush more than once
per second.

Test plan

CI

Migration plan

Configure on staging, push to prod.

Observability plan

N/A

Documentation Changes

N/A

This allows us to, for example, set the dirty log writer's fragment
write interval to 1s so that the dirty log won't flush more than once
per second.
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Dec 10, 2025

Allow overriding dirty log writer options via config

The PR introduces an optional dirty field on LogServerConfig, enabling operators to specify a separate LogWriterOptions for the dirty log writer while defaulting to the existing writer settings. Runtime initialization paths now use config.dirty.as_ref().unwrap_or(&config.writer).clone() so the dirty log writer inherits the override when provided and continues to use the main writer configuration otherwise.

Key Changes

• Added optional dirty field of type Option<LogWriterOptions> to LogServerConfig with serde defaults
• Updated LogServer::try_from_config and dirty log initialization to read from config.dirty and fall back to config.writer

Affected Areas

rust/log-service/src/lib.rs

This summary was automatically generated by @propel-code-bot

@rescrv rescrv merged commit ba0f1ec into main Dec 16, 2025
122 of 125 checks passed
@rescrv rescrv deleted the rescrv/dirty-log-config branch December 16, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants