-
Notifications
You must be signed in to change notification settings - Fork 45
[Validation] moved fields pydantic to validation #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AmitJ98
commented
Jan 21, 2026
- fixed + removed unnecessary pydantic validation
- changed pydantic validation to match the backend validations
- created a strict validation for integration fields
- updated pyproject.toml
- changed pydantic validation to match the backend validations - created a strict validation for integration fields - updated pyproject.toml
Summary of ChangesHello @AmitJ98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the data validation strategy for integration fields by centralizing validation logic into a new module, moving away from scattered Pydantic regex patterns. This change aims to align frontend validation more closely with backend requirements, enhance data integrity, and streamline future validation efforts. It also includes minor adjustments to data model field definitions and updates to project dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageflashpoint
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors Pydantic validations for integration fields, moving some regex-based validations from Pydantic fields to a new FieldsValidation class. It also updates package versions and adjusts constant values. The changes aim to centralize and standardize validation logic. However, there are a few areas for improvement, including redundant code, an incorrect docstring, and a logical flaw in the new validation class that could lead to incomplete validation.
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Outdated
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Outdated
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Outdated
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Show resolved
Hide resolved
packages/mp/src/mp/validate/pre_build_validation/integrations/fields_validation.py
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new FieldsValidation class to centralize regex-based validation for integration fields, moving this logic out of the Pydantic models. This improves modularity and consistency in validation. The PR also includes a version bump for the mp package and updates a dependency. There are a few instances of redundant or False and or "" in assignments that can be simplified, and a minor inconsistency in regex usage within the new validation file.