Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.4.x #1516

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Merge 0.4.x #1516

merged 5 commits into from
Mar 15, 2024

Conversation

pitdicker
Copy link
Collaborator

The rename from LocalResult to MappedLocalTime caused a lot of merge conflicts.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 57.37705% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 94.01%. Comparing base (0fa2a7f) to head (d286f93).

Files Patch % Lines
src/offset/local/tz_info/rule.rs 8.33% 22 Missing ⚠️
src/offset/mod.rs 62.85% 13 Missing ⚠️
src/offset/local/tz_info/timezone.rs 16.66% 10 Missing ⚠️
src/format/parsed.rs 33.33% 4 Missing ⚠️
src/datetime/tests.rs 66.66% 2 Missing ⚠️
src/offset/local/unix.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            0.5.x    #1516   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          37       37           
  Lines       16814    16830   +16     
=======================================
+ Hits        15807    15823   +16     
  Misses       1007     1007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc Sorry, can't merge without you 😄

afbeelding

@pitdicker
Copy link
Collaborator Author

pitdicker commented Mar 15, 2024

@djc Can you please approve this PR?

@pitdicker pitdicker merged commit d286f93 into 0.5.x Mar 15, 2024
34 of 35 checks passed
@pitdicker pitdicker deleted the merge_0.4.x branch March 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants