Convert methods on TimeDelta
to return Result
#1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept
TimeDelta::{checked_add, checked_sub}
like they are, returning anOption
. That seems in line withchecked_add
on integers.We are now at a point where clean-ups are possible. The last commit gets rid of the
expect(ok!(/* ... */))
that developed while parts of the API returnedResult
and parts returnedOption
.Once this PR and #1537 land we can get rid of the
ok!
andtry_opt!
macros.