Release v0.11.0 #90
Merged
Release v0.11.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federkasten
reviewed
Jan 22, 2024
README.md
Outdated
Comment on lines
34
to
35
| We fixed following `varity.vcf-to-hgvs` implementation. | ||
| It is inconvenient to throw an exception in `vcf-variant->protein-hgvs` when variants overlapping a boundary of exon/intron even if `vcf-variant->coding-dna-hgvs` succeed in `vcf-to-hgvs.vcf-variant->hgvs`. So we changed to return nil. |
There was a problem hiding this comment.
Suggested change
| We fixed following `varity.vcf-to-hgvs` implementation. | |
| It is inconvenient to throw an exception in `vcf-variant->protein-hgvs` when variants overlapping a boundary of exon/intron even if `vcf-variant->coding-dna-hgvs` succeed in `vcf-to-hgvs.vcf-variant->hgvs`. So we changed to return nil. | |
| We fixed the `varity.vcf-to-hgvs` implementation. | |
| It is confusing to throw the exception in `vcf-variant->protein-hgvs` when a variant overlaps the exon-intron boundaries, even if coding DNA HGVS is available. So we changed the behavior to return protein HGVS as `nil`. |
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - Return protein-hgvs nil when variants overlapping exon/intron boundaries. [#89](https://github.com/chrovis/varity/pull/89) |
There was a problem hiding this comment.
Suggested change
| - Return protein-hgvs nil when variants overlapping exon/intron boundaries. [#89](https://github.com/chrovis/varity/pull/89) | |
| - Return protein HGVS as `nil` if a variant overlaps exon-intron boundaries. [#89](https://github.com/chrovis/varity/pull/89) |
federkasten
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes following PR.
#89