Fixing up the git support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
|
|
||
|
|
||
| public static string TestPath(string path) |
There was a problem hiding this comment.
Clean up the spacing above this
|
Not too bad, there are few things to clean up and we always suggest that you don't do a pull request from your master branch. It doesn't allow you to do anything more with the code until we make a decision on your PR. Not a good situation for anyone. Fix up those couple of things and send another PR from a branch, then close and reference this one so the two get linked. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous git support was quite fragile, so I've given it a bit of a tidy.