Use datelibrary to compare months

[eltonvus]

Nowadays we rely on JavaScript dates when checking whether or not a day belongs to the same month. Which leads us to a problem, because depending on the timezone configured, we can jump or be behind by a day.

However, when using momentjs.com/timezone/, it is necessary to rely on dateLibrary, to obtain the currentMonth instead of using the JavaScript date.

[mkszepp]

LGTM, thank you

[mkszepp]

released in v1.0.1

[Techn1x]

Just an FYI - this will cause issues in the unmaintained plugin ember-power-calendar-date-fns - which only caters for "day" usage of isSame() from dateLibrary

https://github.com/makepanic/ember-power-calendar-date-fns/blob/441c403c4d838a454c7f62e07a803a25e3cf76d0/addon/unlocalized.js#L113-L120

That's not a problem for this package, but it may be reported as an issue. The error looks like this

global failure: unsupported parameter: isSame(Thu Apr 04 2024 00:49:44 GMT+0000 (Coordinated Universal Time),month)

(pasted here to help others with search)

I use a local copy of the date-fns plugin util anyway, so I've justed updated my local copy of isSame()

[miguelcobain]

@Techn1x I think that's a bug on ember-power-calendar-date-fns, IMO.

The unit argument is there, so it should work for any unit.
Perhaps you could PR your fix there?

[Techn1x]

I think that's a bug on ember-power-calendar-date-fns, IMO.

yes that's what I meant by That's not a problem for this package

The unit argument is there, so it should work for any unit.
Perhaps you could PR your fix there?

The problem is the maintainer is unresponsive and we can't get anything merged there, eg makepanic/ember-power-calendar-date-fns#54

My comment was to highlight that the unmaintained plugin is now going to have issues.

[miguelcobain]

I see. That's unfortunate. Useful to have this info here then. 👍

[Techn1x]

It's probably overdue for a fork. Maybe I'll do it at some point if nobody else does

[mkszepp]

@miguelcobain @Techn1x thanks for this info. Unlucky that we are running inside an unsupported case after this change :(

As the other packages is not anymore maintained and the maintainer doesn't response, i think the best solution is to bring the ember-power-calendar-date-fns as extra package inside this repo and than we publish it with an other scope. So we have every future changes in our hand.
While porting the meta pakages, we should convert date-fns meta packages also to TS, so everything is modernized like the rest.

Also our other meta packages like moment and luxon package we should transfer.

After this migration we have the most used meta packages all in one place and we can give support to every package...

I will look to find time in next days to to that (atm i'm a little bit busy)

[mkszepp]

@Techn1x for the moment i have extended / updated my fork (makepanic/ember-power-calendar-date-fns#54)

Changes:

• Update date-fns to v3
• extend isSame