Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

610 atol and rtol cannot be specified in solver options #612

Merged

Conversation

augeorge
Copy link
Collaborator

torchdiffeq uses rtol and atol as separate arguments - i.e. torchdiffeq(rtol, atol, method, solver_options).
this PR exposes those arguments in the sampling, calibration, and optimization (ouu.py) functions in interfaces.py as well as adds tests.

  • added rtol and atol arguments to sample, calibration, and optimize interfaces
  • added test cases for sample, calibration, and optimization using different rtol and atol values.

@augeorge augeorge requested a review from djinnome September 17, 2024 21:13
@augeorge augeorge linked an issue Sep 17, 2024 that may be closed by this pull request
@augeorge
Copy link
Collaborator Author

@djinnome

@djinnome
Copy link
Contributor

This also adds atol and rtol parameters to ensemble_calibrate and ensemble_sample

@SamWitty
Copy link
Contributor

Rather than have atol and rtol be separate arguments, could we extract them from solver_options if they're available?

@augeorge
Copy link
Collaborator Author

Rather than have atol and rtol be separate arguments, could we extract them from solver_options if they're available?

@djinnome @SamWitty atol and rtol have been moved into solver_options

Copy link
Contributor

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @augeorge

@djinnome djinnome merged commit 08cf9fc into main Sep 18, 2024
5 checks passed
@djinnome djinnome deleted the 610-atol-and-rtol-cannot-be-specified-in-solver_options branch September 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atol and rtol cannot be specified in solver_options
3 participants