Skip to content

Added different types of fixed interventions to optimize #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

anirban-chaudhuri
Copy link
Contributor

optimize can now handle fixed interventions on:

  • static parameter interventions (already existed)
  • static state interventions
  • dynamic parameter interventions
  • dynamic state interventions
    Note that the fixed dynamic interventions might compromise the optimizer's performance so extra care should be taken when using them.

@anirban-chaudhuri anirban-chaudhuri added integration Tasks for integration with TA4 feature request labels Nov 13, 2024
@anirban-chaudhuri anirban-chaudhuri self-assigned this Nov 13, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anirban-chaudhuri anirban-chaudhuri added the awaiting review PR submitter awaiting code review from reviewer label Nov 14, 2024
Copy link
Contributor

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving despite my minor housekeeping comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this file from this PR? The only change in this file is metadata from running it with a different virtual environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main into this branch but the metadata changes remained. Not exactly sure how to undo the metadata changes. I am going to go ahead and merge this PR since it will not make any difference to the file currently on main.

@anirban-chaudhuri anirban-chaudhuri merged commit 2f910c9 into main Dec 6, 2024
5 checks passed
@anirban-chaudhuri anirban-chaudhuri deleted the ac-fixedint-optimize branch December 6, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer feature request integration Tasks for integration with TA4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dynamic parameter/state interventions in optimize as fixed interventions
2 participants