-
Notifications
You must be signed in to change notification settings - Fork 9
Added different types of fixed interventions to optimize #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving despite my minor housekeeping comments.
docs/source/interfaces.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file from this PR? The only change in this file is metadata from running it with a different virtual environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged main into this branch but the metadata changes remained. Not exactly sure how to undo the metadata changes. I am going to go ahead and merge this PR since it will not make any difference to the file currently on main.
optimize
can now handle fixed interventions on:Note that the fixed dynamic interventions might compromise the optimizer's performance so extra care should be taken when using them.