Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing setup.cfg to use most recent mira #638

Merged
merged 3 commits into from
Jan 8, 2025
Merged

changing setup.cfg to use most recent mira #638

merged 3 commits into from
Jan 8, 2025

Conversation

sabinala
Copy link
Contributor

@sabinala sabinala commented Dec 18, 2024

(1) Updating setup.cfg to use the most recent mira version

(2) Changing python_requires = >=3.8 to python_requires = >=3.9 on line 27 to avoid this error Error: Version 3.8 with arch x64 not found when Python 3.8 is unavailable

@sabinala
Copy link
Contributor Author

@djinnome Update: steps (1) and (2) did not fix the problem, so I tried step (3):

(3) Changing python-version to [3.9, '3.10', '3.11'] in both .github/workflows/test.yml and .github/workflows/lint.yml

@sabinala sabinala added WIP PR submitter still making changes, not ready for review and removed WIP PR submitter still making changes, not ready for review labels Dec 18, 2024
@sabinala sabinala requested a review from djinnome December 18, 2024 22:14
@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2025

@djinnome checks have passed, this is ready!

@sabinala sabinala added the awaiting review PR submitter awaiting code review from reviewer label Jan 8, 2025
Copy link
Contributor

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@djinnome djinnome merged commit 0845bea into main Jan 8, 2025
7 checks passed
@djinnome djinnome deleted the sa-update-mira branch January 8, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants