Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing applymap to map #639

Merged
merged 1 commit into from
Jan 9, 2025
Merged

changing applymap to map #639

merged 1 commit into from
Jan 9, 2025

Conversation

sabinala
Copy link
Contributor

@sabinala sabinala commented Jan 8, 2025

Replaced pandas.DataFrame.applymap with .map to avoid Pandas deprecation warning per @liunelson. Subsumes PR #622.

@sabinala sabinala mentioned this pull request Jan 8, 2025
Closed
@sabinala sabinala requested a review from djinnome January 8, 2025 19:11
@sabinala sabinala added the awaiting review PR submitter awaiting code review from reviewer label Jan 8, 2025
@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2025

@djinnome checks have passed, ready for approval.

djinnome
djinnome approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djinnome djinnome merged commit 6a41b1a into main Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djinnome djinnome djinnome approved these changes

Assignees
No one assigned
Labels
awaiting review PR submitter awaiting code review from reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabinala @djinnome