connectivity: check disrupt client deployment if enabled. #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
requested review from
christarazi and
asauber
and removed request for
christarazi
asauber
approved these changes
Jul 22, 2024
The disrupt test client Pods establish connections to the disrupt server clients. Only after the connections are established does the readiness probe become healthy. Currently, we do not check if the clients have become healthy before proceeding. This can lead to confusing CI failures, even if you do an early sanity check, as there may not be any restarts to report right after doing setup. To improve this, this commit will now cause setup to wait for the deployment to become ready. Initial failures to connect will cause the setup step to fail. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/check-disrupt-deployment-early
branch
from
f064f7d
to
eeeaa9c
Compare
|
/test |
tklauser
requested changes
Sep 18, 2024
|
@tklauser Oh right, forgot about that change, I believe this was opened prior to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disrupt test client Pods establish connections to the disrupt server clients. Only after the connections are established does the readiness probe become healthy.
Currently, we do not check if the clients have become healthy before proceeding.
This can lead to confusing CI failures, even if you do an early sanity check test (which asserts no pod restarts), there may not be any restarts to report right after doing setup.
To improve this, this commit will now cause setup to wait for the deployment to become ready. Initial failures to connect will cause the setup step to fail fast rather than proceeding with subsequent upgrade tests.
This should also help differentiate disrupt connection issues that aren't related to any upgrade steps.