.github: use netcat to check hubble port-forward success #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
approved these changes
Nov 6, 2024
aanm
approved these changes
Nov 6, 2024
Signed-off-by: devodev <abalexandrebarone@gmail.com>
devodev
force-pushed
the
pr/devodev/fix-ci-hubble-native-port-forward2
branch
from
4c60b84
to
e8f20f8
Compare
christarazi
approved these changes
Nov 6, 2024
|
I think the AKS test failure is a flaky one, if someone with appropriate permissions could re-run it, that would be great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more robust method for checking if hubble port-forward is successful using netcat.
Do note that the workflows use
on.pull_request_targettherefore the changes will not be reflected in this PR checks, but we've tested these on the isovalent CI with success.CC @michi-covalent
Will fix upcoming CI failure caused by: cilium/cilium#35483