Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize verifier repo. #15

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Initialize verifier repo. #15

merged 6 commits into from
Aug 2, 2024

Conversation

taotao-circle
Copy link
Contributor

@taotao-circle taotao-circle commented Jul 31, 2024

I squash all history to prepare for the open source.

Copy link

github-actions bot commented Jul 31, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

.licenseignore Outdated Show resolved Hide resolved
.licenseignore Outdated
solana-dapp
ethereum
iniparser
hardhat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

.licenseignore Outdated
@@ -1 +1,14 @@
pkg:npm/borsh
pkg:npm/borsh%40%5E0.2.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the @ between the package and the version should be percent-encoded. I tested using the purl parser from the dependency-review-action, and it ends up lumping the version in with the package name:

> parsePURL('pkg:npm/%40bcoe/v8-coverage%40%5E0.2.3')
{
  type: 'npm',
  namespace: '@bcoe',
  name: 'v8-coverage@^0.2.3',
  version: null,
  original: 'pkg:npm/%40bcoe/v8-coverage%40%5E0.2.3',
  error: null
}

Using the @ symbol there it parses correctly:

> parsePURL('pkg:npm/%40bcoe/v8-coverage@%5E0.2.3')
{
  type: 'npm',
  namespace: '@bcoe',
  name: 'v8-coverage',
  version: '^0.2.3',
  original: 'pkg:npm/%40bcoe/v8-coverage@%5E0.2.3',
  error: null
}

(incidentally, it doesn't look like the percent encoding is required at all with this action; 'pkg:npm/@bcoe/v8-coverage@^0.2.3' parses correctly)

It also doesn't look like it's necessary to specify version here at all as only the package type and name are matched in the dependency-review-action, so you could safely remove the versions entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jscaltreto it's one of the check flow requires that (basic workflows/scan/...)

@taotao-circle
Copy link
Contributor Author

@jscaltreto see I changed it back to the @. The basic flow fails.

@taotao-circle taotao-circle merged commit ad72e14 into master Aug 2, 2024
5 checks passed
@taotao-circle taotao-circle deleted the k6-squash branch August 2, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants