Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration-test] add click to python deps for sby #35

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

unlsycn
Copy link
Contributor

@unlsycn unlsycn commented Nov 27, 2024

Signed-off-by: unlsycn <unlsycn@unlsycn.com>
@fabianschuiki
Copy link
Contributor

Very cool, thanks a lot! Would it make sense to add a short test to the sby script that checks whether a simple formal proof runs successfully? Maybe some simple SV file with an assert and a corresponding *.sby script that does a formal check of the assert?

@unlsycn
Copy link
Contributor Author

unlsycn commented Dec 14, 2024

Very cool, thanks a lot! Would it make sense to add a short test to the sby script that checks whether a simple formal proof runs successfully? Maybe some simple SV file with an assert and a corresponding *.sby script that does a formal check of the assert?

I think this is just an image repo and the CIRCT integration test can check it natively.

@fabianschuiki
Copy link
Contributor

Sounds good! Looks like a conflict has come up in the Dockerfile. Could you take a look what's going on there before we land this?

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabianschuiki fabianschuiki merged commit 9bf9d81 into circt:trunk Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants